1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
// Copyright lowRISC contributors (OpenTitan project).
// Licensed under the Apache License, Version 2.0, see LICENSE for details.
// SPDX-License-Identifier: Apache-2.0

use anyhow::{bail, ensure, Context, Result};
use once_cell::sync::Lazy;
use regex::Regex;
use serde_annotate::Annotate;
use serialport::TTYPort;
use std::any::Any;
use std::cell::Cell;
use std::cell::RefCell;
use std::collections::hash_map::Entry;
use std::collections::HashMap;
use std::fs;
use std::io::Read;
use std::io::Write;
use std::marker::PhantomData;
use std::path::{Path, PathBuf};
use std::rc::{Rc, Weak};
use std::time::Duration;

use crate::debug::openocd::OpenOcdJtagChain;
use crate::io::gpio::{GpioBitbanging, GpioMonitoring, GpioPin};
use crate::io::i2c::Bus;
use crate::io::jtag::{JtagChain, JtagParams};
use crate::io::spi::Target;
use crate::io::uart::Uart;
use crate::transport::chip_whisperer::board::Board;
use crate::transport::chip_whisperer::ChipWhisperer;
use crate::transport::common::fpga::{ClearBitstream, FpgaProgram};
use crate::transport::common::uart::flock_serial;
use crate::transport::MaintainConnection;
use crate::transport::{
    Capabilities, Capability, SetJtagPins, Transport, TransportError, TransportInterfaceType,
    UpdateFirmware,
};
use crate::util::usb::UsbBackend;

pub mod c2d2;
pub mod dfu;
pub mod gpio;
pub mod i2c;
pub mod servo_micro;
pub mod spi;
pub mod ti50;
pub mod uart;

pub use c2d2::C2d2Flavor;
pub use dfu::HyperdebugDfu;
pub use servo_micro::ServoMicroFlavor;
pub use ti50::Ti50Flavor;

/// Implementation of the Transport trait for HyperDebug based on the
/// Nucleo-L552ZE-Q.
pub struct Hyperdebug<T: Flavor> {
    spi_interface: BulkInterface,
    i2c_interface: Option<BulkInterface>,
    cmsis_interface: Option<BulkInterface>,
    uart_interfaces: HashMap<String, UartInterface>,
    cached_io_interfaces: CachedIo,
    inner: Rc<Inner>,
    current_firmware_version: Option<String>,
    cmsis_google_capabilities: Cell<Option<u16>>,
    phantom: PhantomData<T>,
}

/// Trait allowing slightly different treatment of USB devices that work almost like a
/// HyperDebug.  E.g. C2D2 and Servo micro.
pub trait Flavor {
    fn gpio_pin(inner: &Rc<Inner>, pinname: &str) -> Result<Rc<dyn GpioPin>>;
    fn spi_index(_inner: &Rc<Inner>, instance: &str) -> Result<(u8, u8)> {
        bail!(TransportError::InvalidInstance(
            TransportInterfaceType::Spi,
            instance.to_string()
        ))
    }
    fn i2c_index(_inner: &Rc<Inner>, instance: &str) -> Result<(u8, i2c::Mode)> {
        bail!(TransportError::InvalidInstance(
            TransportInterfaceType::I2c,
            instance.to_string()
        ))
    }
    fn get_default_usb_vid() -> u16;
    fn get_default_usb_pid() -> u16;
    fn load_bitstream(_fpga_program: &FpgaProgram) -> Result<()> {
        Err(TransportError::UnsupportedOperation.into())
    }
    fn clear_bitstream(_clear: &ClearBitstream) -> Result<()> {
        Err(TransportError::UnsupportedOperation.into())
    }
    fn perform_initial_fw_check() -> bool {
        true
    }
}

pub const VID_GOOGLE: u16 = 0x18d1;
pub const PID_HYPERDEBUG: u16 = 0x520e;

/// Index of a single USB "interface", with its associated IN and OUT
/// endpoints.  Used to instantiate e.g. SPI trait.
#[derive(Copy, Clone)]
pub struct BulkInterface {
    interface: u8,
    in_endpoint: u8,
    out_endpoint: u8,
}

pub struct UartInterface {
    interface: u8,
    tty: PathBuf,
}

impl UartInterface {
    pub fn new(interface: u8, tty: PathBuf) -> Self {
        Self { interface, tty }
    }
}

impl<T: Flavor> Hyperdebug<T> {
    const USB_CLASS_VENDOR: u8 = 255;
    const USB_SUBCLASS_UART: u8 = 80;
    const USB_SUBCLASS_SPI: u8 = 81;
    const USB_SUBCLASS_I2C: u8 = 82;
    const USB_PROTOCOL_UART: u8 = 1;
    const USB_PROTOCOL_SPI: u8 = 2;
    const USB_PROTOCOL_I2C: u8 = 1;

    /// CMSIS extension for HyperDebug.
    const CMSIS_DAP_CUSTOM_COMMAND_GOOGLE_INFO: u8 = 0x80;

    /// Sub-command for reading set of Google extension capabilities.
    const GOOGLE_INFO_CAPABILITIES: u8 = 0x00;

    // Values for capabilities bitfield
    const GOOGLE_CAP_I2C: u16 = 0x0001;
    const GOOGLE_CAP_I2C_DEVICE: u16 = 0x0002;
    const GOOGLE_CAP_GPIO_MONITORING: u16 = 0x0004;
    const GOOGLE_CAP_GPIO_BITBANGING: u16 = 0x0008;
    const GOOGLE_CAP_UART_QUEUE_CLEAR: u16 = 0x0010;

    /// Establish connection with a particular HyperDebug.
    pub fn open(
        usb_vid: Option<u16>,
        usb_pid: Option<u16>,
        usb_serial: Option<&str>,
    ) -> Result<Self> {
        let mut device = UsbBackend::new(
            usb_vid.unwrap_or_else(T::get_default_usb_vid),
            usb_pid.unwrap_or_else(T::get_default_usb_pid),
            usb_serial,
        )?;

        let path = PathBuf::from("/sys/bus/usb/devices");

        let mut console_tty: Option<PathBuf> = None;
        let mut spi_interface: Option<BulkInterface> = None;
        let mut i2c_interface: Option<BulkInterface> = None;
        let mut cmsis_interface: Option<BulkInterface> = None;
        let mut uart_interfaces: HashMap<String, UartInterface> = HashMap::new();

        let config_desc = device.active_config_descriptor()?;
        let current_firmware_version = if let Some(idx) = config_desc.description_string_index() {
            if let Ok(current_firmware_version) = device.read_string_descriptor_ascii(idx) {
                if let Some(released_firmware_version) = dfu::official_firmware_version()? {
                    if T::perform_initial_fw_check()
                        && current_firmware_version != released_firmware_version
                    {
                        log::warn!(
                            "Current HyperDebug firmware version is {}, newest release is {}, Consider running `opentitantool transport update-firmware`",
                            current_firmware_version,
                            released_firmware_version,
                        );
                    }
                }
                Some(current_firmware_version)
            } else {
                None
            }
        } else {
            None
        };
        // Iterate through each USB interface, discovering e.g. supported UARTs.
        for interface in config_desc.interfaces() {
            for interface_desc in interface.descriptors() {
                let ports = device
                    .port_numbers()?
                    .iter()
                    .map(|id| id.to_string())
                    .collect::<Vec<String>>()
                    .join(".");
                let interface_path = path
                    .join(format!("{}-{}", device.bus_number(), ports))
                    .join(format!(
                        "{}-{}:{}.{}",
                        device.bus_number(),
                        ports,
                        config_desc.number(),
                        interface.number()
                    ));
                // Check the class/subclass/protocol of this USB interface.
                if interface_desc.class_code() == Self::USB_CLASS_VENDOR
                    && interface_desc.sub_class_code() == Self::USB_SUBCLASS_UART
                    && interface_desc.protocol_code() == Self::USB_PROTOCOL_UART
                {
                    // A serial console interface, use the ascii name to determine if it is the
                    // HyperDebug Shell, or a UART forwarding interface.
                    let idx = match interface_desc.description_string_index() {
                        Some(idx) => idx,
                        None => continue,
                    };
                    let interface_name = match device.read_string_descriptor_ascii(idx) {
                        Ok(interface_name) => interface_name,
                        _ => continue,
                    };

                    if !device.kernel_driver_active(interface.number())? {
                        device.attach_kernel_driver(interface.number())?;
                        // Wait for udev rules to apply proper permissions to new device.
                        std::thread::sleep(Duration::from_millis(100));
                    }

                    if interface_name.ends_with("Shell") {
                        // We found the "main" control interface of HyperDebug, allowing textual
                        // commands to be sent, to e.g. manipulate GPIOs.
                        console_tty = Some(Self::find_tty(&interface_path)?);
                    } else {
                        // We found an UART forwarding USB interface.
                        let uart = UartInterface {
                            interface: interface.number(),
                            tty: Self::find_tty(&interface_path)?,
                        };
                        uart_interfaces.insert(interface_name.to_string(), uart);
                    }
                    continue;
                }
                if interface_desc.class_code() == Self::USB_CLASS_VENDOR
                    && interface_desc.sub_class_code() == Self::USB_SUBCLASS_SPI
                    && interface_desc.protocol_code() == Self::USB_PROTOCOL_SPI
                {
                    // We found the SPI forwarding USB interface (this one interface allows
                    // multiplexing physical SPI ports.)
                    Self::find_endpoints_for_interface(
                        &mut spi_interface,
                        &interface,
                        &interface_desc,
                    )?;
                    continue;
                }
                if interface_desc.class_code() == Self::USB_CLASS_VENDOR
                    && interface_desc.sub_class_code() == Self::USB_SUBCLASS_I2C
                    && interface_desc.protocol_code() == Self::USB_PROTOCOL_I2C
                {
                    // We found the I2C forwarding USB interface (this one interface allows
                    // multiplexing physical I2C ports.)
                    Self::find_endpoints_for_interface(
                        &mut i2c_interface,
                        &interface,
                        &interface_desc,
                    )?;
                    continue;
                }
                if interface_desc.class_code() == Self::USB_CLASS_VENDOR {
                    // A serial console interface, use the ascii name to determine if it is the
                    // HyperDebug Shell, or a UART forwarding interface.
                    let idx = match interface_desc.description_string_index() {
                        Some(idx) => idx,
                        None => continue,
                    };
                    let interface_name = match device.read_string_descriptor_ascii(idx) {
                        Ok(interface_name) => interface_name,
                        _ => continue,
                    };
                    if interface_name.ends_with("CMSIS-DAP") {
                        // We found the I2C forwarding USB interface (this one interface allows
                        // multiplexing physical I2C ports.)
                        Self::find_endpoints_for_interface(
                            &mut cmsis_interface,
                            &interface,
                            &interface_desc,
                        )?;
                        continue;
                    }
                }
            }
        }
        let result = Hyperdebug::<T> {
            spi_interface: spi_interface.ok_or_else(|| {
                TransportError::CommunicationError("Missing SPI interface".to_string())
            })?,
            i2c_interface,
            cmsis_interface,
            uart_interfaces,
            cached_io_interfaces: CachedIo {
                gpio: Default::default(),
                spis: Default::default(),
                i2cs_by_name: Default::default(),
                i2cs_by_index: Default::default(),
                uarts: Default::default(),
            },
            inner: Rc::new(Inner {
                console_tty: console_tty.ok_or_else(|| {
                    TransportError::CommunicationError("Missing console interface".to_string())
                })?,
                conn: RefCell::new(Weak::new()),
                usb_device: RefCell::new(device),
                selected_spi: Cell::new(0),
            }),
            current_firmware_version,
            cmsis_google_capabilities: Cell::new(None),
            phantom: PhantomData,
        };
        Ok(result)
    }

    /// Locates the /dev/ttyUSBn node corresponding to a given interface in the sys directory
    /// tree, e.g. /sys/bus/usb/devices/1-4/1-4:1.0 .
    fn find_tty(path: &Path) -> Result<PathBuf> {
        for entry in fs::read_dir(path).context(format!("find TTY: read_dir({:?})", path))? {
            let entry = entry.context(format!("find TTY: entity {:?}", path))?;
            if let Ok(filename) = entry.file_name().into_string() {
                if filename.starts_with("tty") {
                    return Ok(PathBuf::from("/dev").join(entry.file_name()));
                }
            }
        }
        Err(TransportError::CommunicationError("Did not find ttyUSBn device".to_string()).into())
    }

    fn find_endpoints_for_interface(
        interface_variable_output: &mut Option<BulkInterface>,
        interface: &rusb::Interface,
        interface_desc: &rusb::InterfaceDescriptor,
    ) -> Result<()> {
        let mut in_endpoint: Option<u8> = None;
        let mut out_endpoint: Option<u8> = None;
        for endpoint_desc in interface_desc.endpoint_descriptors() {
            if endpoint_desc.transfer_type() != rusb::TransferType::Bulk {
                continue;
            }
            match endpoint_desc.direction() {
                rusb::Direction::In => {
                    ensure!(
                        in_endpoint.is_none(),
                        TransportError::CommunicationError("Multiple IN endpoints".to_string())
                    );
                    in_endpoint.replace(endpoint_desc.address());
                }
                rusb::Direction::Out => {
                    ensure!(
                        out_endpoint.is_none(),
                        TransportError::CommunicationError("Multiple OUT endpoints".to_string())
                    );
                    out_endpoint.replace(endpoint_desc.address());
                }
            }
        }
        match (in_endpoint, out_endpoint) {
            (Some(in_endpoint), Some(out_endpoint)) => {
                ensure!(
                    interface_variable_output.is_none(),
                    TransportError::CommunicationError("Multiple identical interfaces".to_string())
                );
                interface_variable_output.replace(BulkInterface {
                    interface: interface.number(),
                    in_endpoint,
                    out_endpoint,
                });
                Ok(())
            }
            _ => bail!(TransportError::CommunicationError(
                "Missing one or more endpoints".to_string()
            )),
        }
    }

    fn get_cmsis_google_capabilities(&self) -> Result<u16> {
        let Some(cmsis_interface) = self.cmsis_interface else {
            // Since this debugger does not advertise any CMSIS USB interface at all, report no
            // Google CMSIS extension capabilites.
            return Ok(0);
        };
        if let Some(capabilities) = self.cmsis_google_capabilities.get() {
            // Return cached value.
            return Ok(capabilities);
        }
        self.inner
            .usb_device
            .borrow_mut()
            .claim_interface(cmsis_interface.interface)?;
        let cmd = [
            Self::CMSIS_DAP_CUSTOM_COMMAND_GOOGLE_INFO,
            Self::GOOGLE_INFO_CAPABILITIES,
        ];
        self.inner
            .usb_device
            .borrow()
            .write_bulk(cmsis_interface.out_endpoint, &cmd)?;
        let mut resp = [0u8; 64];
        let bytecount = self
            .inner
            .usb_device
            .borrow()
            .read_bulk(cmsis_interface.in_endpoint, &mut resp)?;
        let resp = &resp[..bytecount];
        // First byte of response is echo of the request header, second byte indicates the number
        // of data bytes to follow.
        ensure!(
            bytecount >= 4 && resp[0] == Self::CMSIS_DAP_CUSTOM_COMMAND_GOOGLE_INFO && resp[1] >= 2,
            TransportError::CommunicationError("Unrecognized CMSIS-DAP response".to_string())
        );
        let capabilities = u16::from_le_bytes([resp[2], resp[3]]);
        self.cmsis_google_capabilities.set(Some(capabilities));
        self.inner
            .usb_device
            .borrow_mut()
            .release_interface(cmsis_interface.interface)?;
        Ok(capabilities)
    }
}

/// Internal state of the Hyperdebug struct, this struct is reference counted such that Gpio,
/// Spi and Uart sub-structs can all refer to this shared data, which is guaranteed to live on,
/// even if the caller lets the outer Hyperdebug struct run out of scope.
pub struct Inner {
    console_tty: PathBuf,
    conn: RefCell<Weak<Conn>>,
    usb_device: RefCell<UsbBackend>,
    selected_spi: Cell<u8>,
}

/// Holds cached IO communication instances(gpio, spi, i2c, uart) that the Hyperdebug struct generates.
/// This way requests for the Hyperdebug Transport struct to create a previously generated instance
/// will return the cached one instead of generating a completely new one.
pub struct CachedIo {
    gpio: RefCell<HashMap<String, Rc<dyn GpioPin>>>,
    spis: RefCell<HashMap<u8, Rc<dyn Target>>>,
    i2cs_by_name: RefCell<HashMap<String, Rc<dyn Bus>>>,
    i2cs_by_index: RefCell<HashMap<u8, Rc<dyn Bus>>>,
    uarts: RefCell<HashMap<PathBuf, Rc<dyn Uart>>>,
}

pub struct Conn {
    console_port: RefCell<TTYPort>,
}

// The way that the HyperDebug allows callers to request optimization for a sequence of operations
// without other `opentitantool` processes meddling with the USB devices, is to let the caller
// hold an `Rc`-reference to the `Conn` struct, thereby keeping the USB connection alive.
impl MaintainConnection for Conn {}

impl Inner {
    /// Establish connection with HyperDebug console USB interface.
    pub fn connect(&self) -> Result<Rc<Conn>> {
        if let Some(conn) = self.conn.borrow().upgrade() {
            // The driver already has a connection, use it.
            return Ok(conn);
        }
        // Establish a new connection.
        let port_name = self
            .console_tty
            .to_str()
            .ok_or(TransportError::UnicodePathError)?;
        let port =
            TTYPort::open(&serialport::new(port_name, 115_200).timeout(Duration::from_millis(100)))
                .context("Failed to open HyperDebug console")?;
        flock_serial(&port, port_name)?;
        let conn = Rc::new(Conn {
            console_port: RefCell::new(port),
        });
        // Return a (strong) reference to the newly opened connection, while keeping a weak
        // reference to the same in this `Inner` object.  The result is that if the caller keeps
        // the strong reference alive long enough, the next invocation of `connect()` will be able
        // to re-use the same instance.  If on the other hand, the caller drops their reference,
        // then the weak reference will not keep the instance alive, and next time a new
        // connection will be made.
        *self.conn.borrow_mut() = Rc::downgrade(&conn);
        Ok(conn)
    }

    /// Send a command to HyperDebug firmware, expecting to receive no output.  Any output will be
    /// reported through an `Err()` return.
    pub fn cmd_no_output(&self, cmd: &str) -> Result<()> {
        let mut unexpected_output: bool = false;
        self.execute_command(cmd, |line| {
            log::warn!("Unexpected HyperDebug output: {}", line);
            unexpected_output = true;
        })?;
        if unexpected_output {
            bail!(TransportError::CommunicationError(format!(
                "Unexpected output to {}",
                cmd
            )));
        }
        Ok(())
    }

    /// Send a command to HyperDebug firmware, expecting to receive a single line of output.  Any
    /// more or less output will be reported through an `Err()` return.
    pub fn cmd_one_line_output(&self, cmd: &str) -> Result<String> {
        let mut result: Option<String> = None;
        let mut unexpected_output: bool = false;
        self.execute_command(cmd, |line| {
            if unexpected_output {
                // Third or subsequent line, report it.
                log::warn!("Unexpected HyperDebug output: {}", line);
            } else if result.is_none() {
                // First line, remember it.
                result = Some(line.to_string());
            } else {
                // Second line, report the first as well as this one.
                log::warn!("Unexpected HyperDebug output: {}", result.as_ref().unwrap());
                log::warn!("Unexpected HyperDebug output: {}", line);
                unexpected_output = true;
            }
        })?;
        if unexpected_output {
            bail!(TransportError::CommunicationError(
                "Unexpected output".to_string()
            ));
        }
        match result {
            None => bail!(TransportError::CommunicationError(format!(
                "No response to command {}",
                cmd
            ))),
            Some(str) => Ok(str),
        }
    }

    /// Send a command to HyperDebug firmware, expecting to receive a single line of output.  Any
    /// more or less output will be reported through an `Err()` return.
    pub fn cmd_one_line_output_match<'a>(
        &self,
        cmd: &str,
        regex: &Regex,
        buf: &'a mut String,
    ) -> Result<regex::Captures<'a>> {
        *buf = self.cmd_one_line_output(cmd)?;
        let Some(captures) = regex.captures(buf) else {
            log::warn!("Unexpected HyperDebug output: {}", buf);
            bail!(TransportError::CommunicationError(
                "Unexpected output".to_string()
            ));
        };
        Ok(captures)
    }

    /// Send a command to HyperDebug firmware, with a callback to receive any output.
    fn execute_command(&self, cmd: &str, callback: impl FnMut(&str)) -> Result<()> {
        // Open console device, if not already open.
        let conn = self.connect()?;
        // Perform requested command, passing any output to callback.
        conn.execute_command(cmd, callback)
    }
}

impl Conn {
    /// Send a command to HyperDebug firmware, with a callback to receive any output.
    fn execute_command(&self, cmd: &str, mut callback: impl FnMut(&str)) -> Result<()> {
        let port: &mut TTYPort = &mut self.console_port.borrow_mut();

        // Send Ctrl-C, followed by the command, then newline.  This will discard any previous
        // partial input, before executing our command.
        port.write(format!("\x03{}\n", cmd).as_bytes())
            .context("writing to HyperDebug console")?;

        // Now process response from HyperDebug.  First we expect to see the echo of the command
        // we just "typed". Then zero, one or more lines of useful output, which we want to pass
        // to the callback, and then a prompt characters, indicating that the output is
        // complete.
        let mut buf = [0u8; 128];
        let mut seen_echo = false;
        let mut len: usize = 0;
        loop {
            // Read more data, appending to existing buffer.
            match port.read(&mut buf[len..]) {
                Ok(rc) => {
                    len += rc;
                    // See if we have one or more lines terminated with endline, if so, process
                    // those and remove from the buffer by shifting the remaning data to the
                    // front of the buffer.
                    let mut line_start = 0;
                    for i in 0..len {
                        if buf[i] == b'\n' {
                            // Found a complete line, process it
                            let mut line_end = i;
                            while line_end > line_start && buf[line_end - 1] == 13 {
                                line_end -= 1;
                            }
                            let line = std::str::from_utf8(&buf[line_start..line_end])
                                .context("utf8 decoding from HyperDebug console")?;
                            if seen_echo {
                                callback(line);
                            } else if line.len() >= 2 && line[line.len() - 2..] == *"^C" {
                                // Expected output from our sending of control character.
                            } else if line.len() >= cmd.len()
                                && line[line.len() - cmd.len()..] == *cmd
                            {
                                // A line ending with the command we sent, assume this is echo,
                                // and that the actual command output will now follow.
                                seen_echo = true;
                            } else if !line.is_empty() {
                                // Unexpected output before or instead of the echo of our command.
                                log::info!("Unexpected output: {:?}", line)
                            }
                            line_start = i + 1;
                        }
                    }
                    // If any lines were processed, remove from the buffer.
                    if line_start > 0 {
                        buf.rotate_left(line_start);
                        len -= line_start;
                    }
                    if seen_echo && buf[0..len] == [b'>', b' '] {
                        // We have seen echo of the command we sent, and now the last we got was a
                        // command prompt, this is what we expect when the command has finished
                        // successfully.
                        return Ok(());
                    }
                }
                Err(error) => return Err(error).context("reading from HyperDebug console"),
            }
        }
    }
}

impl<T: Flavor> Transport for Hyperdebug<T> {
    fn capabilities(&self) -> Result<Capabilities> {
        Ok(Capabilities::new(
            Capability::UART
                | Capability::UART_NONBLOCKING
                | Capability::GPIO
                | Capability::GPIO_MONITORING
                | Capability::GPIO_BITBANGING
                | Capability::SPI
                | Capability::SPI_DUAL
                | Capability::SPI_QUAD
                | Capability::I2C
                | Capability::JTAG,
        ))
    }

    fn apply_default_configuration(&self) -> Result<()> {
        self.inner.cmd_no_output("reinit")
    }

    // Create SPI Target instance, or return one from a cache of previously created instances.
    fn spi(&self, instance: &str) -> Result<Rc<dyn Target>> {
        let (enable_cmd, idx) = T::spi_index(&self.inner, instance)?;
        if let Some(instance) = self.cached_io_interfaces.spis.borrow().get(&idx) {
            return Ok(Rc::clone(instance));
        }
        let instance: Rc<dyn Target> = Rc::new(spi::HyperdebugSpiTarget::open(
            &self.inner,
            &self.spi_interface,
            enable_cmd,
            idx,
        )?);
        self.cached_io_interfaces
            .spis
            .borrow_mut()
            .insert(idx, Rc::clone(&instance));
        Ok(instance)
    }

    // Create I2C Target instance, or return one from a cache of previously created instances.
    fn i2c(&self, name: &str) -> Result<Rc<dyn Bus>> {
        if let Some(instance) = self.cached_io_interfaces.i2cs_by_name.borrow().get(name) {
            return Ok(Rc::clone(instance));
        }
        let (idx, mode) = T::i2c_index(&self.inner, name)?;
        if let Some(instance) = self.cached_io_interfaces.i2cs_by_index.borrow().get(&idx) {
            self.cached_io_interfaces
                .i2cs_by_name
                .borrow_mut()
                .insert(name.to_string(), Rc::clone(instance));
            return Ok(Rc::clone(instance));
        }
        let cmsis_google_capabilities = self.get_cmsis_google_capabilities()?;
        let instance: Rc<dyn Bus> = Rc::new(
            match (
                cmsis_google_capabilities & Self::GOOGLE_CAP_I2C != 0,
                self.cmsis_interface.as_ref(),
                self.i2c_interface.as_ref(),
            ) {
                (true, Some(cmsis_interface), _) => i2c::HyperdebugI2cBus::open(
                    &self.inner,
                    cmsis_interface,
                    true, /* cmsis_encapsulation */
                    cmsis_google_capabilities & Self::GOOGLE_CAP_I2C_DEVICE != 0,
                    idx,
                    mode,
                )?,
                (_, _, Some(i2c_interface)) => i2c::HyperdebugI2cBus::open(
                    &self.inner,
                    i2c_interface,
                    false, /* cmsis_encapsulation */
                    false, /* supports_i2c_device */
                    idx,
                    mode,
                )?,
                _ => bail!(TransportError::InvalidInstance(
                    TransportInterfaceType::I2c,
                    name.to_string()
                )),
            },
        );
        self.cached_io_interfaces
            .i2cs_by_index
            .borrow_mut()
            .insert(idx, Rc::clone(&instance));
        self.cached_io_interfaces
            .i2cs_by_name
            .borrow_mut()
            .insert(name.to_string(), Rc::clone(&instance));
        Ok(instance)
    }

    // Create Uart instance, or return one from a cache of previously created instances.
    fn uart(&self, instance: &str) -> Result<Rc<dyn Uart>> {
        match self.uart_interfaces.get(instance) {
            Some(uart_interface) => {
                if let Some(instance) = self
                    .cached_io_interfaces
                    .uarts
                    .borrow()
                    .get(&uart_interface.tty)
                {
                    return Ok(Rc::clone(instance));
                }
                let supports_clearing_queues =
                    self.get_cmsis_google_capabilities()? & Self::GOOGLE_CAP_UART_QUEUE_CLEAR != 0;
                let instance: Rc<dyn Uart> = Rc::new(uart::HyperdebugUart::open(
                    &self.inner,
                    uart_interface,
                    supports_clearing_queues,
                )?);
                self.cached_io_interfaces
                    .uarts
                    .borrow_mut()
                    .insert(uart_interface.tty.clone(), Rc::clone(&instance));
                Ok(instance)
            }
            _ => Err(TransportError::InvalidInstance(
                TransportInterfaceType::Uart,
                instance.to_string(),
            )
            .into()),
        }
    }

    // Create GpioPin instance, or return one from a cache of previously created instances.
    fn gpio_pin(&self, pinname: &str) -> Result<Rc<dyn GpioPin>> {
        Ok(
            match self
                .cached_io_interfaces
                .gpio
                .borrow_mut()
                .entry(pinname.to_string())
            {
                Entry::Vacant(v) => {
                    let u = v.insert(T::gpio_pin(&self.inner, pinname)?);
                    Rc::clone(u)
                }
                Entry::Occupied(o) => Rc::clone(o.get()),
            },
        )
    }

    // Create GpioMonitoring instance.
    fn gpio_monitoring(&self) -> Result<Rc<dyn GpioMonitoring>> {
        // GpioMonitoring does not carry any state, so returning a new instance every time is
        // harmless (save for some memory usage).
        if self.get_cmsis_google_capabilities()? & Self::GOOGLE_CAP_GPIO_MONITORING != 0 {
            Ok(Rc::new(gpio::HyperdebugGpioMonitoring::open(
                &self.inner,
                self.cmsis_interface,
            )?))
        } else {
            // Older HyperDebug firmware does not support GPIO monitoring via binary CMSIS-DAP
            // protocol.  Not passing the `cmsis_interface` below forces the code to use textual
            // console protocol as fallback.
            Ok(Rc::new(gpio::HyperdebugGpioMonitoring::open(
                &self.inner,
                None,
            )?))
        }
    }

    fn gpio_bitbanging(&self) -> Result<Rc<dyn GpioBitbanging>> {
        ensure!(
            self.get_cmsis_google_capabilities()? & Self::GOOGLE_CAP_GPIO_BITBANGING != 0,
            TransportError::InvalidInterface(TransportInterfaceType::GpioBitbanging),
        );
        // GpioBitbanging does not carry any state, so returning a new instance every time is
        // harmless (save for some memory usage).
        let Some(cmsis_interface) = self.cmsis_interface else {
            bail!(TransportError::InvalidInterface(
                TransportInterfaceType::GpioBitbanging
            ));
        };
        Ok(Rc::new(gpio::HyperdebugGpioBitbanging::open(
            &self.inner,
            cmsis_interface,
        )?))
    }

    fn dispatch(&self, action: &dyn Any) -> Result<Option<Box<dyn Annotate>>> {
        if let Some(update_firmware_action) = action.downcast_ref::<UpdateFirmware>() {
            let usb_vid = self.inner.usb_device.borrow().get_vendor_id();
            let usb_pid = self.inner.usb_device.borrow().get_product_id();
            dfu::update_firmware(
                &mut self.inner.usb_device.borrow_mut(),
                self.current_firmware_version.as_deref(),
                &update_firmware_action.firmware,
                update_firmware_action.progress.as_ref(),
                update_firmware_action.force,
                usb_vid,
                usb_pid,
            )
        } else if let Some(jtag_set_pins) = action.downcast_ref::<SetJtagPins>() {
            match (
                &jtag_set_pins.tclk,
                &jtag_set_pins.tms,
                &jtag_set_pins.tdi,
                &jtag_set_pins.tdo,
                &jtag_set_pins.trst,
            ) {
                (Some(tclk), Some(tms), Some(tdi), Some(tdo), Some(trst)) => {
                    self.inner.cmd_no_output(&format!(
                        "jtag set-pins {} {} {} {} {}",
                        tclk.get_internal_pin_name()
                            .ok_or(TransportError::InvalidOperation)?,
                        tms.get_internal_pin_name()
                            .ok_or(TransportError::InvalidOperation)?,
                        tdi.get_internal_pin_name()
                            .ok_or(TransportError::InvalidOperation)?,
                        tdo.get_internal_pin_name()
                            .ok_or(TransportError::InvalidOperation)?,
                        trst.get_internal_pin_name()
                            .ok_or(TransportError::InvalidOperation)?,
                    ))?;
                    Ok(None)
                }
                _ => Err(TransportError::UnsupportedOperation.into()),
            }
        } else if let Some(fpga_program) = action.downcast_ref::<FpgaProgram>() {
            T::load_bitstream(fpga_program).map(|_| None)
        } else if let Some(clear) = action.downcast_ref::<ClearBitstream>() {
            T::clear_bitstream(clear).map(|_| None)
        } else {
            Err(TransportError::UnsupportedOperation.into())
        }
    }

    fn jtag(&self, opts: &JtagParams) -> Result<Box<dyn JtagChain + '_>> {
        ensure!(
            self.cmsis_interface.is_some(),
            TransportError::InvalidInterface(TransportInterfaceType::Jtag),
        );
        // Tell OpenOCD to use its CMSIS-DAP driver, and to connect to the same exact USB
        // HyperDebug device that we are.
        let usb_device = self.inner.usb_device.borrow();
        let new_jtag = Box::new(OpenOcdJtagChain::new(
            &format!(
                "{}; cmsis_dap_vid_pid 0x{:04x} 0x{:04x}; adapter serial \"{}\";",
                include_str!(env!("openocd_cmsis_dap_adapter_cfg")),
                usb_device.get_vendor_id(),
                usb_device.get_product_id(),
                usb_device.get_serial_number(),
            ),
            opts,
        )?);
        Ok(new_jtag)
    }

    /// The way that the HyperDebug driver allows callers to request optimization for a sequence
    /// of operations without other `opentitantool` processes meddling with the USB devices, is to
    /// let the caller hold an `Rc`-reference to the `Conn` struct, thereby keeping the USB
    /// connection alive.  Callers should only hold ond to the object as long as they can
    /// guarantee that no other `opentitantool` processes simultaneously attempt to access the
    /// same HyperDebug USB device.
    fn maintain_connection(&self) -> Result<Rc<dyn MaintainConnection>> {
        Ok(self.inner.connect()?)
    }
}

/// A `StandardFlavor` is a plain Hyperdebug board.
pub struct StandardFlavor;

impl Flavor for StandardFlavor {
    fn gpio_pin(inner: &Rc<Inner>, pinname: &str) -> Result<Rc<dyn GpioPin>> {
        Ok(Rc::new(gpio::HyperdebugGpioPin::open(inner, pinname)?))
    }

    fn spi_index(inner: &Rc<Inner>, instance: &str) -> Result<(u8, u8)> {
        match instance.parse() {
            Err(_) => {
                // Execute a "spi info" command to look up the numeric index corresponding to the
                // given alphanumeric SPI instance name.
                let mut buf = String::new();
                let captures = inner
                    .cmd_one_line_output_match(
                        &format!("spi info {}", instance),
                        &SPI_REGEX,
                        &mut buf,
                    )
                    .map_err(|_| {
                        TransportError::InvalidInstance(
                            TransportInterfaceType::Spi,
                            instance.to_string(),
                        )
                    })?;
                Ok((
                    spi::USB_SPI_REQ_ENABLE,
                    captures.get(1).unwrap().as_str().parse().unwrap(),
                ))
            }
            Ok(n) => Ok((spi::USB_SPI_REQ_ENABLE, n)),
        }
    }

    fn i2c_index(inner: &Rc<Inner>, instance: &str) -> Result<(u8, i2c::Mode)> {
        // Execute a "i2c info" command to look up the numeric index corresponding to the
        // given alphanumeric I2C instance name.
        let mut buf = String::new();
        let captures = inner
            .cmd_one_line_output_match(&format!("i2c info {}", instance), &SPI_REGEX, &mut buf)
            .map_err(|_| {
                TransportError::InvalidInstance(TransportInterfaceType::I2c, instance.to_string())
            })?;
        let mode = match captures.get(4) {
            Some(c) if c.as_str().starts_with('d') => i2c::Mode::Device,
            _ => i2c::Mode::Host,
        };
        Ok((captures.get(1).unwrap().as_str().parse().unwrap(), mode))
    }

    fn get_default_usb_vid() -> u16 {
        VID_GOOGLE
    }

    fn get_default_usb_pid() -> u16 {
        PID_HYPERDEBUG
    }
}

/// A `ChipWhispererFlavor` is a Hyperdebug attached to a Chip Whisperer board.  Furthermore,
/// both the Hyperdebug and Chip Whisperer board USB interfaces are attached to the host.
/// Hyperdebug is used for all IO with the Chip Whisperer board except for bitstream
/// programming.
pub struct ChipWhispererFlavor<B: Board> {
    _phantom: PhantomData<B>,
}

impl<B: Board> Flavor for ChipWhispererFlavor<B> {
    fn gpio_pin(inner: &Rc<Inner>, pinname: &str) -> Result<Rc<dyn GpioPin>> {
        StandardFlavor::gpio_pin(inner, pinname)
    }
    fn spi_index(inner: &Rc<Inner>, instance: &str) -> Result<(u8, u8)> {
        StandardFlavor::spi_index(inner, instance)
    }
    fn i2c_index(inner: &Rc<Inner>, instance: &str) -> Result<(u8, i2c::Mode)> {
        StandardFlavor::i2c_index(inner, instance)
    }
    fn get_default_usb_vid() -> u16 {
        StandardFlavor::get_default_usb_vid()
    }
    fn get_default_usb_pid() -> u16 {
        StandardFlavor::get_default_usb_pid()
    }
    fn load_bitstream(fpga_program: &FpgaProgram) -> Result<()> {
        // First, try to establish a connection to the native Chip Whisperer interface
        // which we will use for bitstream loading.
        let board = ChipWhisperer::<B>::new(None, None, None, &[])?;

        // Program the FPGA bitstream.
        log::info!("Programming the FPGA bitstream.");
        let usb = board.device.borrow();
        usb.spi1_enable(false)?;
        usb.fpga_program(&fpga_program.bitstream, fpga_program.progress.as_ref())?;
        Ok(())
    }
    fn clear_bitstream(_clear: &ClearBitstream) -> Result<()> {
        let board = ChipWhisperer::<B>::new(None, None, None, &[])?;
        let usb = board.device.borrow();
        usb.spi1_enable(false)?;
        usb.clear_bitstream()?;
        Ok(())
    }
}

static SPI_REGEX: Lazy<Regex> =
    Lazy::new(|| Regex::new("^ +([0-9]+) ([^ ]+) ([0-9]+) bps(?: ([hd])[^ ]*)?").unwrap());